undici.stream ignores throwOnError

[mdashlw]

Bug Description

undici.stream/Dispatcher.stream accepts RequestOptions which extends DispatchOptions which includes throwOnError to throw on 4xx and 5xx HTTP errors, but completely ignores it and calls the factory regardless of the status code.

Reproducible By

import fs from "node:fs";
import undici from "undici";

await undici.stream(
  "https://httpbin.org/status/502",
  { throwOnError: true },
  () => fs.createWriteStream("httpbin_502.txt")
);

Successfully creates an empty httpbin_502.txt (because httpbin.org sends empty body on /status)

Expected Behavior

ResponseStatusCodeError: Response status code 502: BAD GATEWAY

Additional context

• throwOnError was introduced in feat: Option to throw on error status codes #1453
• the current code for request:

  undici/lib/api/api-request.js

  Line 95 in 0a7ba72

  if (this.throwOnError && statusCode >= 400) {

• stream lacks that code:

  undici/lib/api/api-stream.js

  Line 92 in 0a7ba72

  const res = this.runInAsyncScope(factory, null, {

[ronag]

PR welcome!

[ronag]

Should do the same on undici.pipeline

[MattBidewell]

If no one else is looking, I've started to take a look at this. :) Have a WIP draft PR here, not finished yet.

#1766

[assalielmehdi]

Hi, I implemented a fix. Can you take a look?