-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websocket wpt tests hangs in CI #1928
Comments
cc @KhafraDev |
I think we should disable the websocket WPTs. What's (probably) happening:
Now that's where I got lost. There is no socket, so theoretically nothing should stop the worker from exiting (even unref'ing the worker doesn't cause it to close). Even if this was fixed, the websocket tests would still fail. I spent many, many hours working on this |
I'm ok with disabling... |
Is the runner a piece of our machinery? In that case we should have a timeout. |
I haven't seen a timeout in some time, I think this is sorted. |
As titled, they often hang and they need to be manually terminated.
This does not happen locally.
The text was updated successfully, but these errors were encountered: