Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from tap to the node core test runner #2267

Closed
mcollina opened this issue Sep 15, 2023 · 9 comments · Fixed by #2746
Closed

Move from tap to the node core test runner #2267

mcollina opened this issue Sep 15, 2023 · 9 comments · Fixed by #2746
Labels
good first issue Good for newcomers

Comments

@mcollina
Copy link
Member

As titled

This could be part of the next semver major that drops old nodes.

@ashutoshdhande
Copy link

Will give a shot at this

@anurag-roy
Copy link
Contributor

@mcollina There are a lot of test files using tap (around 150).

Are we looking to migrate all of them in one PR or migrating part by part is fine?

@pmarchini
Copy link
Member

Hey!

Given the large number of tests and the need to meticulously avoid false positives, would it be more effective to split the test suites into separate PRs?

For instance, test:cookies appears to be easily portable independently of other suites.

How about we create a list of these suites to distribute the workload and more effectively monitor the outcomes?

@Uzlopak
Copy link
Contributor

Uzlopak commented Jan 27, 2024

Is there something like t.plan in node:test?

@anurag-roy
Copy link
Contributor

@Uzlopak There isn't, we are using @matteo.collina/tspl package instead of t.plan

Example usage here.

@Uzlopak
Copy link
Contributor

Uzlopak commented Feb 8, 2024

I am on this now.

I opened a PR #2719 for an example transformation.
Also I will split the necessary work into smaller PRs to reduce the review work.

@Uzlopak
Copy link
Contributor

Uzlopak commented Feb 9, 2024

Opened #2720 and #2721 to incrementally prepare the following PR.

@Uzlopak
Copy link
Contributor

Uzlopak commented Feb 12, 2024

LOL. I created basically 6 batches and lost the following stuff, which I stashed in git.

So please review and merge the open PRs. Then I can continue to migrate it.

@Uzlopak
Copy link
Contributor

Uzlopak commented Feb 13, 2024

Nice. Its done.

Maybe we can do the same in fastify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants