http2

[ronag]

Adding http2 might be easier than I thought.

See, https://github.com/devsnek/snekfetch/blob/master/src/node/socket.js

[mcollina]

I've recently been asked how I would approach adding HTTP2 support to Undici. The starting point should be to implement an HTTP2 version of

undici/lib/core/client.js

Line 71 in 252b676

class Client extends EventEmitter {

on top of an HTTP2 session.

[Nytelife26]

I will make an attempt to work on this in a fork, as HTTP/2 support is one of my only qualms with undici (great job so far team). I will post an update here with my progress and I hope to submit a PR.

[mcollina]

Go for it!

[Nytelife26]

I will be waiting on the following pull requests to complete their lifecycle before I begin, to avoid risking late-stage merge conflicts:

• refactor: cleanup and restructure #606
• feat: redirect #603
• feat: Added RedirectPool. #600

[mcollina]

I think this could be started right now without waiting for those. I would start writing an Http2Client that wraps a Http2Session object. None of those PRs touches those internals.

[Nytelife26]

That's fine by me, then. I just questioned whether, given that the PRs at present change the structure and workings of some parts of the client, you'd want the HTTP/2 variants to inherit those improvements and thus need to wait for a merge, but if not I can start tonight when I get home.

[mcollina]

There won't be much conflict to start with. There will be as you move up to implement Http2Pool and then a cross-protocol Agent.

[Nytelife26]

It seems like the most effective solution, then, would be to start it and then follow along with the PRs when I get to those parts so I can ensure the development of the HTTP/2 variants stays up to date and won't create any delays or merge conflicts when the time comes.

[mcollina]

Yes exactly!

[Nytelife26]

Alright, I'll start with Http2Session and Http2Client tonight then, and from then forth engage in side-by-side development with relevant pull requests. Thank you!

[mcollina]

Have you got any progress @Nytelife26 ? How is it going?

[ronag]

I think with #620 this should be even easier. You just need to create a new client implementing the Dispatcher interface.

[Nytelife26]

How is it going?

Apologies, I wasn't able to start on it just yet, been very busy with college. I'll be doing that now since I have free time. And, yes, I love what you guys did with unifying under Dispatcher, that makes life much easier.

[ronag]

duplicate #399