Skip to content

fix(fetch): prevent infinite retry loop on 401 responses #4756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
killagu wants to merge 2 commits into from
+52 −2
Closed

fix(fetch): prevent infinite retry loop on 401 responses #4756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36886de
fix(fetch): prevent infinite retry loop on 401 responses
killagu Jan 22, 2026
c33ff33
test(fetch): add test for 401 response not causing infinite loop
killagu Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/web/fetch/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1447,8 +1447,10 @@ function includesCredentials (url) {
* @param {object|string} navigable
*/
function isTraversableNavigable (navigable) {
// TODO
return true
// Node.js is not a browser environment, there is no traversable navigable
// that can prompt the user for credentials. Returning true would cause
// infinite retry loops on 401 responses.
return false
}

class EnvironmentSettingsObjectBase {
Expand Down
48 changes: 48 additions & 0 deletions test/fetch/401-statuscode-no-infinite-loop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
'use strict'

const { fetch } = require('../..')
const { createServer } = require('node:http')
const { once } = require('node:events')
const { test } = require('node:test')

const { closeServerAsPromise } = require('../utils/node-http')

test('Receiving a 401 status code should not cause infinite retry loop', async (t) => {
let requestCount = 0

const server = createServer({ joinDuplicateHeaders: true }, (req, res) => {
requestCount++
res.statusCode = 401
res.setHeader('WWW-Authenticate', 'Basic realm="test"')
res.end('Unauthorized')
}).listen(0)

t.after(closeServerAsPromise(server))
await once(server, 'listening')

const response = await fetch(`http://localhost:${server.address().port}`)

t.assert.strictEqual(response.status, 401)
t.assert.strictEqual(requestCount, 1, 'should only make one request, not retry infinitely')
})

test('Receiving a 401 status code with credentials include should not cause infinite retry loop', async (t) => {
let requestCount = 0

const server = createServer({ joinDuplicateHeaders: true }, (req, res) => {
requestCount++
res.statusCode = 401
res.setHeader('WWW-Authenticate', 'Basic realm="test"')
res.end('Unauthorized')
}).listen(0)

t.after(closeServerAsPromise(server))
await once(server, 'listening')

const response = await fetch(`http://localhost:${server.address().port}`, {
credentials: 'include'
})

t.assert.strictEqual(response.status, 401)
t.assert.strictEqual(requestCount, 1, 'should only make one request, not retry infinitely')
})
Loading