-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Old-style net API deprecation #1762
Comments
I basically agree but this
should be done before the upcoming merge. |
No objections from me. |
For sure the way to go 👍 |
Can you add right message by yourself? I have not excellent english, you see :) |
@djphoenix issue number 2 from your list above can be ticked off, see http://nodemcu.readthedocs.io/en/latest/en/modules/net/#netcreateconnection |
That PR is now ready. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hey, more dead code to eliminate. I'll take this on, too, as part of my rampaging around the network stack. |
And dead documentation, too 😉 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I can`t see anything to do here anymore. Documentation looks good and the implementation also does not allow for options anymore. Can we close this? |
Now we have new APIs for creation TLS connections and UDP sockets, and so old APIs that kept only for backward compatibility (just convenience calls):
net.createConnection(net.UDP)
->net.createUDPSocket()
net.createServer(net.UDP)
->net.createUDPSocket()
net.createConnection(net.TCP, 1)
->tls.createConnection()
I propose to:
net.createConnection()
behaviour to create plain tcp connection by default (without options).The text was updated successfully, but these errors were encountered: