Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change charset parameter value from "utf8" to "utf-8" in default cont… #330

Merged

Conversation

flaheathrenn
Copy link
Contributor

…ent-type headers

Fixes issue #329

@flaheathrenn flaheathrenn deleted the default-charset-utf8-to-utf-8 branch February 19, 2024 13:35
@flaheathrenn flaheathrenn restored the default-charset-utf8-to-utf-8 branch February 19, 2024 13:36
@flaheathrenn flaheathrenn reopened this Feb 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4a2d964) 89.54% compared to head (ef26873) 89.54%.

Files Patch % Lines
lib/invoker.js 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files          10       10           
  Lines         306      306           
=======================================
  Hits          274      274           
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@lholmquist lholmquist merged commit ed9e7df into nodeshift:main Feb 20, 2024
7 checks passed
@mohsen0
Copy link

mohsen0 commented Feb 20, 2024

@matejvasek @lholmquist we appreciate if we could have a release, or ETA for it.
Thank you

@matejvasek
Copy link
Contributor

cc @lance ^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants