Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export HUSKY=0 in a config has no effect #1393

Closed
alecmev opened this issue Feb 12, 2024 · 3 comments · May be fixed by YoutacRandS-VA/pokenode-ts#2, apiiro-snyk/JavaGuide#2, WontonSam/Phiahplay-gaming#99, WontonSam/cachimanexpress.js-Design-Patterns-Third-Edition#193 or WontonSam/Phiahplay-gaming#103
Closed

export HUSKY=0 in a config has no effect #1393

alecmev opened this issue Feb 12, 2024 · 3 comments · May be fixed by YoutacRandS-VA/pokenode-ts#2, apiiro-snyk/JavaGuide#2, WontonSam/Phiahplay-gaming#99, WontonSam/cachimanexpress.js-Design-Patterns-Third-Edition#193 or WontonSam/Phiahplay-gaming#103

Comments

@alecmev
Copy link

alecmev commented Feb 12, 2024

$HUSKY is evaluated before the configs are sourced, so its presence doesn't trigger exit 0:

husky/husky

Lines 2 to 14 in 095a4fe

H="$HUSKY"
[ "$H" = "2" ] && set -x
h="${0##*/}"
s="${0%/*/*}/$h"
[ ! -f "$s" ] && exit 0
for f in "${XDG_CONFIG_HOME:-$HOME/.config}/husky/init.sh" "$HOME/.huskyrc"; do
# shellcheck disable=SC1090
[ -f "$f" ] && . "$f"
done
[ "$H" = "0" ] && exit 0

Are the docs out-ot-date and I'm expected to put export H=0 in init.sh? Or something else is wrong?
@typicode
Copy link
Owner

Good catch. It's a bug. It was moved there to fix #1358. I'll publish a new version.

@typicode typicode reopened this Feb 12, 2024
@typicode
Copy link
Owner

Should be good 👍

@alecmev
Copy link
Author

alecmev commented Feb 16, 2024

It is, thank you!

@alecmev alecmev closed this as completed Feb 16, 2024
@YoutacRandS-VA YoutacRandS-VA mentioned this issue Jun 20, 2024
Open
@apiiro-snyk apiiro-snyk mentioned this issue Jul 2, 2024
Open
This was referenced Jul 16, 2024
Open
Open
Open
Open
@WontonSam WontonSam mentioned this issue Jul 20, 2024
Open
@snyk-io snyk-io bot mentioned this issue Jul 24, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this issue Aug 8, 2024
Open
This was referenced Aug 8, 2024
Closed
Open
Open
@andyrooger andyrooger mentioned this issue Aug 8, 2024
Closed
This was referenced Aug 9, 2024
Open
Open
@andyrooger andyrooger mentioned this issue Aug 9, 2024
Closed
@NOUIY NOUIY mentioned this issue Aug 20, 2024
Open
This was referenced Aug 24, 2024
Open
Open
@WontonSam WontonSam mentioned this issue Aug 26, 2024
Open
@NOUIY NOUIY mentioned this issue Aug 28, 2024
Open
@Sec32fun32 Sec32fun32 mentioned this issue Sep 2, 2024
Open
@NOUIY NOUIY mentioned this issue Sep 11, 2024
Open
@santiagoSS99 santiagoSS99 mentioned this issue Sep 12, 2024
Closed
This was referenced Sep 27, 2024
Open
Open
Open
@santiagoSS99 santiagoSS99 mentioned this issue Oct 3, 2024
Closed
@WontonSam WontonSam mentioned this issue Oct 5, 2024
Open
This was referenced Oct 28, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade husky from 8.0.3 to 9.0.11 YoutacRandS-VA/pokenode-ts
[Snyk] Upgrade husky from 9.0.10 to 9.0.11 apiiro-snyk/JavaGuide
[Snyk] Upgrade husky from 2.7.0 to 9.0.11 WontonSam/Phiahplay-gaming
[Snyk] Upgrade husky from 4.2.3 to 9.0.11 WontonSam/cachimanexpress.js-Design-Patterns-Third-Edition
[Snyk] Upgrade husky from 2.7.0 to 9.0.11 WontonSam/Phiahplay-gaming
[Snyk] Upgrade husky from 2.7.0 to 9.0.11 WontonSam/Phiahplay-gaming
[Snyk] Upgrade husky from 2.7.0 to 9.0.11 WontonSam/Phiahplay-gaming
[Snyk] Upgrade husky from 2.7.0 to 9.0.11 WontonSam/Phiahplay-gaming
[Snyk] Upgrade husky from 9.0.11 to 9.1.0 abdulrahman305/csharp-language-server-protocol
[Snyk] Upgrade husky from 9.0.11 to 9.1.0 nodeshift/opossum-prometheus
2 participants
@alecmev @typicode