Skip to content

Commit ad34157

Browse files
committed
fix(Dependencies): Fix due changes in graphql-compose@1.0.0
1 parent 20cf246 commit ad34157

35 files changed

+3588
-82
lines changed

package.json

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,11 @@
2525
"homepage": "https://github.com/nodkz/graphql-compose-mongoose",
2626
"dependencies": {
2727
"babel-runtime": "6.11.6",
28-
"graphql-type-json": "0.1.3",
2928
"object-path": "0.11.2"
3029
},
3130
"peerDependencies": {
3231
"graphql": ">=0.7.1 || >=0.8.0",
33-
"graphql-compose": ">=0.1.0 || >=1.0.0",
32+
"graphql-compose": ">=1.0.0",
3433
"graphql-compose-connection": ">=1.0.0",
3534
"mongoose": ">=4.0.0"
3635
},
@@ -62,18 +61,6 @@
6261
"sane": "1.4.1",
6362
"semantic-release": "4.3.5"
6463
},
65-
"scripts": {
66-
"build": "npm run build-cjs && npm run build-flow && npm run build-es",
67-
"build-cjs": "rimraf lib && babel src --ignore __tests__,__mocks__ -d lib",
68-
"build-es": "rimraf es && BABEL_ENV=es babel src --ignore __tests__,__mocks__ -d es",
69-
"build-flow": "find ./src -name '*.js' -not -path '*/__*' | while read filepath; do cp $filepath `echo $filepath | sed 's/\\/src\\//\\/lib\\//g'`.flow; done",
70-
"coverage": "nyc npm run test",
71-
"lint": "eslint src test *.js",
72-
"test": "babel-node ./node_modules/.bin/_mocha --compilers js:babel-core/register --reporter dot --timeout 20000 --require ./resources/mocha-bootload src/**/__tests__/**/*-test.js",
73-
"watch": "babel-node ./resources/watch.js",
74-
"link": "npm link graphql && npm link graphql-compose && npm link graphql-compose-connection && npm link mongoose && npm link",
75-
"semantic-release": "semantic-release pre && npm publish && semantic-release post"
76-
},
7764
"config": {
7865
"commitizen": {
7966
"path": "./node_modules/cz-conventional-changelog"
@@ -90,5 +77,17 @@
9077
"lcov",
9178
"text"
9279
]
80+
},
81+
"scripts": {
82+
"build": "npm run build-cjs && npm run build-flow && npm run build-es",
83+
"build-cjs": "rimraf lib && babel src --ignore __tests__,__mocks__ -d lib",
84+
"build-es": "rimraf es && BABEL_ENV=es babel src --ignore __tests__,__mocks__ -d es",
85+
"build-flow": "find ./src -name '*.js' -not -path '*/__*' | while read filepath; do cp $filepath `echo $filepath | sed 's/\\/src\\//\\/lib\\//g'`.flow; done",
86+
"coverage": "nyc npm run test",
87+
"lint": "eslint src test *.js",
88+
"test": "babel-node ./node_modules/.bin/_mocha --compilers js:babel-core/register --reporter dot --timeout 20000 --require ./resources/mocha-bootload src/**/__tests__/**/*-test.js",
89+
"watch": "babel-node ./resources/watch.js",
90+
"link": "npm link graphql && npm link graphql-compose && npm link graphql-compose-connection && npm link mongoose && npm link",
91+
"semantic-release": "semantic-release pre && npm publish && semantic-release post"
9392
}
9493
}

src/__mocks__/mongooseCommon.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ mongoose.connection.on('error', (err) => {
1414
throw new Error(err);
1515
});
1616

17+
mongoose.connection.on('connected', () => {
18+
console.log('Mongoose default connection open to ' + uri);
19+
});
1720

1821
function dropDBs(done) {
1922
mongoose.connection.db.dropDatabase(() => {

src/__tests__/composeWithMongoose-test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,14 +129,14 @@ describe('composeWithMongoose ->', () => {
129129
describe('createResolvers()', () => {
130130
it('should not be called if opts.resolvers === false', () => {
131131
const tc = composeWithMongoose(UserModel, { resolvers: false });
132-
expect(tc.getResolvers().getKeys()).is.empty;
132+
expect(tc.getResolvers().keys()).is.empty;
133133
});
134134

135135
it('should be called if opts.resolvers not exists or has value', () => {
136136
const tc = composeWithMongoose(UserModel);
137-
expect(tc.getResolvers().getKeys()).is.not.empty;
137+
expect(Array.from(tc.getResolvers().keys())).is.not.empty;
138138
const tc2 = composeWithMongoose(UserModel, { resolvers: {} });
139-
expect(tc2.getResolvers().getKeys()).is.not.empty;
139+
expect(Array.from(tc2.getResolvers().keys())).is.not.empty;
140140
});
141141

142142
it('should not provide resolver if opts.resolvers.[resolverName] === false', () => {
@@ -149,7 +149,7 @@ describe('composeWithMongoose ->', () => {
149149
},
150150
},
151151
});
152-
const resolverKeys = tc2.getResolvers().getKeys();
152+
const resolverKeys = Array.from(tc2.getResolvers().keys());
153153
expect(resolverKeys).to.not.include('removeById');
154154
expect(resolverKeys).include.members(['findMany', 'updateOne', 'updateMany']);
155155
});

src/__tests__/fieldConverter-test.js

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ import {
1111
GraphQLObjectType,
1212
graphql,
1313
} from 'graphql';
14-
import GraphQLJSON from 'graphql-type-json';
1514
import {
1615
GraphQLDate,
1716
GraphQLBuffer,
1817
GraphQLGeneric,
18+
GraphQLJSON,
1919
} from 'graphql-compose';
20-
import { UserModel } from '../__mocks__/userModel.js';
20+
import { UserModel } from '../__mocks__/userModel';
2121
import {
2222
deriveComplexType,
2323
getFieldsFromModel,
@@ -33,14 +33,6 @@ import {
3333
import { composeWithMongoose } from '../composeWithMongoose';
3434
import GraphQLMongoID from '../types/mongoid';
3535

36-
/*
37-
Object.prototype.getClassName = function getClassName() {
38-
const funcNameRegex = /function (.{1,})\(/;
39-
const results = (funcNameRegex).exec((this).constructor.toString());
40-
return (results && results.length > 1) ? results[1] : '';
41-
};
42-
*/
43-
4436
describe('fieldConverter', () => {
4537
const fields = getFieldsFromModel(UserModel);
4638
const fieldNames = Object.keys(fields);

src/composeWithMongoose.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export function composeWithMongoose(
3737

3838
createInputType(typeComposer, opts.inputType);
3939

40-
if (!opts.hasOwnProperty('resolvers') || opts.resolvers !== false) {
40+
if (!{}.hasOwnProperty.call(opts, 'resolvers') || opts.resolvers !== false) {
4141
createResolvers(model, typeComposer, opts.resolvers || {});
4242
}
4343

@@ -111,21 +111,21 @@ export function createResolvers(
111111
opts: typeConverterResolversOpts
112112
): void {
113113
const names = resolvers.getAvailableNames();
114-
names.forEach(resolverName => {
115-
if (!opts.hasOwnProperty(resolverName) || opts[resolverName] !== false) {
114+
names.forEach((resolverName) => {
115+
if (!{}.hasOwnProperty.call(opts, resolverName) || opts[resolverName] !== false) {
116116
const createResolverFn = resolvers[resolverName];
117117
if (createResolverFn) {
118118
const resolver = createResolverFn(
119119
model,
120120
typeComposer,
121121
opts[resolverName] || {}
122122
);
123-
typeComposer.setResolver(resolver);
123+
typeComposer.setResolver(resolverName, resolver);
124124
}
125125
}
126126
});
127127

128-
if (!opts.hasOwnProperty('connection') || opts.connection !== false) {
128+
if (!{}.hasOwnProperty.call(opts, 'connection') || opts.connection !== false) {
129129
prepareConnectionResolver(typeComposer, opts.connection ? opts.connection : {});
130130
}
131131
}

src/fieldsConverter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
GraphQLDate,
99
GraphQLBuffer,
1010
GraphQLGeneric,
11+
GraphQLJSON,
1112
GQLReference,
1213
} from 'graphql-compose';
1314

@@ -19,7 +20,6 @@ import {
1920
GraphQLEnumType,
2021
GraphQLObjectType,
2122
} from 'graphql';
22-
import GraphQLJSON from 'graphql-type-json';
2323
import GraphQLMongoID from './types/mongoid';
2424
import typeStorage from './typeStorage';
2525

src/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,6 @@ export default composeWithMongoose;
77

88
export * from './fieldsConverter';
99
export {
10+
composeWithMongoose,
1011
typeStorage as mongooseTypeStorage,
1112
};

src/resolvers/__tests__/count-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import { expect } from 'chai';
44
import { GraphQLInt } from 'graphql';
55
import { Resolver } from 'graphql-compose';
6-
import { UserModel } from '../../__mocks__/userModel.js';
6+
import { UserModel } from '../../__mocks__/userModel';
77
import count from '../count';
88
import { composeWithMongoose } from '../../composeWithMongoose';
99

src/resolvers/__tests__/createOne-test.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
/* @flow */
22

33
import { expect } from 'chai';
4-
import { GraphQLNonNull } from 'graphql';
4+
import { GraphQLNonNull, GraphQLObjectType } from 'graphql';
55
import { Resolver, TypeComposer } from 'graphql-compose';
6-
import { UserModel } from '../../__mocks__/userModel.js';
6+
import { UserModel } from '../../__mocks__/userModel';
77
import createOne from '../createOne';
88
import { composeWithMongoose } from '../../composeWithMongoose';
99
import GraphQLMongoID from '../../types/mongoid';
@@ -130,9 +130,13 @@ describe('createOne() ->', () => {
130130

131131
it('should reuse existed outputType', () => {
132132
const outputTypeName = `CreateOne${UserTypeComposer.getTypeName()}Payload`;
133-
typeStorage.set(outputTypeName, 'EXISTED_TYPE');
133+
const existedType = new GraphQLObjectType({
134+
name: outputTypeName,
135+
fields: () => ({}),
136+
});
137+
typeStorage.set(outputTypeName, existedType);
134138
const outputType = createOne(UserModel, UserTypeComposer).getOutputType();
135-
expect(outputType).to.equal('EXISTED_TYPE');
139+
expect(outputType).to.equal(existedType);
136140
});
137141
});
138142
});

src/resolvers/__tests__/findById-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import { expect } from 'chai';
44
import { GraphQLNonNull } from 'graphql';
55
import { Resolver } from 'graphql-compose';
6-
import { UserModel } from '../../__mocks__/userModel.js';
6+
import { UserModel } from '../../__mocks__/userModel';
77
import findById from '../findById';
88
import GraphQLMongoID from '../../types/mongoid';
99
import { composeWithMongoose } from '../../composeWithMongoose';

0 commit comments

Comments
 (0)