fix(Resolvers): Provide documents with all fields to updateById and updateOne

Before this fix mongoose load only that field which was in graphql projection. But mongoose models

may have hooks that require fields which not loaded. So now update resolvers load full documents

from database.

Author: nodkz

src/resolvers/__tests__/updateById-test.js

@@ -20,13 +20,7 @@ describe('updateById() ->', () => {
   let user1;
   let user2;
 
-  before('clear UserModel collection', (done) => {
-    UserModel.collection.drop(() => {
-      done();
-    });
-  });
-
-  before('add test user document to mongoDB', () => {
+  beforeEach('init UserModel collection', (done) => {
     user1 = new UserModel({
       name: 'userName1',
       skills: ['js', 'ruby', 'php', 'python'],
@@ -41,10 +35,12 @@ describe('updateById() ->', () => {
       relocation: true,
     });
 
-    return Promise.all([
-      user1.save(),
-      user2.save(),
-    ]);
+    UserModel.collection.drop(() => {
+      Promise.all([
+        user1.save(),
+        user2.save(),
+      ]).then(() => done());
+    });
   });
 
   beforeEach(() => {
@@ -131,24 +127,22 @@ describe('updateById() ->', () => {
       expect(result).have.deep.property('record.name', checkedName);
     });
 
-    it('should extract projection from record for findById', async () => {
-      const checkedName = 'anyName123';
+    it('should pass empty projection to findById and got full document data', async () => {
       const result = await updateById(UserModel, UserTypeComposer).resolve({
         args: {
           record: {
             _id: user1.id,
-            name: checkedName,
           },
         },
         projection: {
           record: {
             name: true,
-            gender: true,
           },
         },
       });
       expect(result).have.deep.property('record.id', user1.id);
-      expect(result).have.deep.property('record.gender');
+      expect(result).have.deep.property('record.name', user1.name);
+      expect(result).have.deep.property('record.gender', user1.gender);
     });
 
     it('should return mongoose document', async () => {

src/resolvers/__tests__/updateOne-test.js

@@ -15,13 +15,7 @@ describe('updateOne() ->', () => {
   let user1;
   let user2;
 
-  before('clear UserModel collection', (done) => {
-    UserModel.collection.drop(() => {
-      done();
-    });
-  });
-
-  before('add test user document to mongoDB', () => {
+  beforeEach('init UserModel collection', (done) => {
     user1 = new UserModel({
       name: 'userName1',
       skills: ['js', 'ruby', 'php', 'python'],
@@ -36,10 +30,12 @@ describe('updateOne() ->', () => {
       relocation: true,
     });
 
-    return Promise.all([
-      user1.save(),
-      user2.save(),
-    ]);
+    UserModel.collection.drop(() => {
+      Promise.all([
+        user1.save(),
+        user2.save(),
+      ]).then(() => done());
+    });
   });
 
   beforeEach(() => {
@@ -158,20 +154,20 @@ describe('updateOne() ->', () => {
       expect(result1.record.id).to.not.equal(result2.record.id);
     });
 
-    it('should extract projection from record for findOne', async () => {
+    it('should pass empty projection to findOne and got full document data', async () => {
       const result = await updateOne(UserModel, UserTypeComposer).resolve({
         args: {
           filter: { _id: user1.id },
         },
         projection: {
           record: {
             name: true,
-            gender: true,
           },
         },
       });
       expect(result).have.deep.property('record.id', user1.id);
-      expect(result).have.deep.property('record.gender');
+      expect(result).have.deep.property('record.name', user1.name);
+      expect(result).have.deep.property('record.gender', user1.gender);
     });
 
     it('should return mongoose document', async () => {
@@ -188,7 +184,7 @@ describe('updateOne() ->', () => {
         beforeRecordMutate: (record) => {
           beforeMutationId = record.id;
           return record;
-        }
+        },
       });
       expect(result.record).instanceof(UserModel);
       expect(beforeMutationId).to.equal(user1.id);

src/resolvers/helpers/projection.js

@@ -4,7 +4,7 @@ import type {
   ExtendedResolveParams,
 } from '../../definition';
 
-export function projectionHelper(resolveParams: ExtendedResolveParams): void {
+export function projectionHelper(resolveParams: ExtendedResolveParams): void { // eslint-disable-line
   const projection = resolveParams.projection;
   if (projection) {
     const flatProjection = {};
@@ -17,6 +17,9 @@ export function projectionHelper(resolveParams: ExtendedResolveParams): void {
         flatProjection[key] = !!projection[key];
       }
     });
-    resolveParams.query = resolveParams.query.select(flatProjection); // eslint-disable-line
+
+    if (Object.keys(flatProjection).length > 0) {
+      resolveParams.query = resolveParams.query.select(flatProjection); // eslint-disable-line
+    }
   }
 }

src/resolvers/updateById.js

@@ -88,18 +88,21 @@ export default function updateById(
 
       resolveParams.args._id = recordData._id;
       delete recordData._id;
-      resolveParams.projection =
-        (resolveParams.projection && resolveParams.projection.record) || {};
+
+      // We should get all data for document, cause Mongoose model may have hooks/middlewares
+      // which required some fields which not in graphql projection
+      // So empty projection returns all fields.
+      resolveParams.projection = {};
 
       return findByIdResolver.resolve(resolveParams)
-        .then(doc => {
+        .then((doc) => {
           if (resolveParams.beforeRecordMutate) {
             return resolveParams.beforeRecordMutate(doc);
           }
           return doc;
         })
         // save changes to DB
-        .then(doc => {
+        .then((doc) => {
           if (!doc) {
             return Promise.reject('Document not found');
           }
@@ -110,7 +113,7 @@ export default function updateById(
           return doc;
         })
         // prepare output payload
-        .then(record => {
+        .then((record) => {
           if (record) {
             return {
               record,

src/resolvers/updateMany.js

@@ -101,7 +101,7 @@ export default function updateMany(
           ? Promise.resolve(resolveParams.beforeQuery(resolveParams.query))
           : resolveParams.query.exec()
         )
-        .then(res => {
+        .then((res) => {
           if (res.ok) {
             return {
               numAffected: res.nModified,

src/resolvers/updateOne.js

@@ -94,26 +94,28 @@ export default function updateOne(
         );
       }
 
-      resolveParams.projection =
-        (resolveParams.projection && resolveParams.projection.record) || {};
+      // We should get all data for document, cause Mongoose model may have hooks/middlewares
+      // which required some fields which not in graphql projection
+      // So empty projection returns all fields.
+      resolveParams.projection = {};
 
       return findOneResolver.resolve(resolveParams)
-        .then(doc => {
+        .then((doc) => {
           if (resolveParams.beforeRecordMutate) {
             return resolveParams.beforeRecordMutate(doc);
           }
           return doc;
         })
         // save changes to DB
-        .then(doc => {
+        .then((doc) => {
           if (recordData) {
             doc.set(recordData);
             return doc.save();
           }
           return doc;
         })
         // prepare output payload
-        .then(record => {
+        .then((record) => {
           if (record) {
             return {
               record,