-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapping of filter switches #16
Comments
I created an endpoint where you can retrieve https://tourism.opendatahub.bz.it/v1/EventShortTypes Type identifies the field where to filter on, Key is the string value to filter Type: CustomTagging Type: TechnologyFields If you want you can also prefilter the Type call at example with |
Hi @RudiThoeni ,
|
Hi Chiara I updated the EventShortTypes Response to be more flexible in future CustomTagging (Identified by Type: CustomTagging)
Filter by TechnologyFields (Identified by Type: TechnologyFields)
Filter by EventType Public,Noi only @sseppi please ask to the design/planning team if they want this functionality on the api? |
@sseppi these points are still open. Could you please give us a feedback? |
Unfortunately Marion is out of office till the 22nd, as soon as she will be back I will ask her and let you know. |
@RudiThoeni could you please add the Italian and German descriptions in EventShortTypes Response? The app will be in three languages (see #20) |
@RudiThoeni just let me know if we don't have the content in three languages, so I can define a strategy with Marion. |
@sseppi no i don't have i will add the same english desc to key de,it and then Marion can provide me the right german italian descs |
@RudiThoeni I would avoid to put the English version also in the other languages. I would prefer to do this filtering directly in the app. In this direction I see two possibilities:
I will then ask Marion to update the data. So we keep the database clean. |
@sseppi Before answering, let me clarify that the descriptions to add to the above endpoint response are relative to switch labels in filters screen. |
@sseppi i think we are mixing up things one point is the text of the filter switches. the second point is the description of an event, this data should be always there, but here it can occur that a language is not there so we have to define a fallback |
@RudiThoeni @chiaraDimension |
Hi Chiara I checked and Eventtype (Public, NOI Only) is now defined as "CustomTagging" in the api. and filterable by All CustomTaggings/TechnologyFields are listed here and you can use the Titles in 'TypeDesc' What is not clear to me is we currently have the Tags Should the app filter display all of this tags to filter on? or only certain tags? If not all Tags are available on the filters i have to include on api side the information on what Tags Dimension let filter on in the app @MarE1991 let's clarify this in our next meeting |
@RudiThoeni @chiaraDimension the app filter should only display the two tags "NOI-Community" and "Public". The other filter options are irrelevant to the app. |
ok thx marion for clarify now i added a flag "Parent": "EventType" where we can filter on for the call what filters to display..... so for dimension this query gives you all info to filter on CustomTagging --> Keys: (NOI Community, Public) example: TechnologyFields --> Keys: (Alpine,Automotive/Automation,Digital,Food,Green) example: |
Hi @RudiThoeni, Filters are dynamic. To get them, we have to call the endpoint
We'll show all filters that we obtain from this endpoint, without any checking. We'll only distinguish between "event type" filters and "technology sector" filters. Questions:
|
@RudiThoeni or @MarE1991 could you please give us some feedback? |
Yes everything is right
|
Thanks, @RudiThoeni!
|
@RudiThoeni @sseppi @chiaraDimension An event can either be public or for NOI-Community only. There are no events with both filters applicable, so it's an OR. Meanwhile, an event can be classified with more technology fields, but normally we choose one, also because on the website there can only be displayed one. So, here is an OR as well I would say. And I would vote for that possibility: |
@pkritzinger we found some issues in filters UI:
2.1 In this case, buttons take too much space 2.2 In this case, the user can not know that there are are filters hidden behind buttons and that he have to scroll: Can you adjust the UI accordingly? |
@chiaraDimension : thanks for your input. We will check the possibilities we have and provide you an updated version for this view. I'll keep you posted. |
@matax87 : looks good, thanks for your input. It might make sense to switch the order of the buttons and put a shadow on the white container, but I'll discuss internally and let you know. Hope that's fine for you! |
@Piiit can you update the title of this issue and the iOS one (noi-techpark/it.bz.noi.community.ios#18) to a more proper feature name? Thank you! |
@matax87 @chiaraDimension Please find the updated version for the filters here (Screens 5&6): I'll send you the respective file per mail since Github does not allow me to upload it. |
@matax87 I am not involved in this issue... @sseppi @MarE1991 What would you like to have as title here? |
For every switch in the UI which is the correspondent parameter we should pass in the API of the events?
The text was updated successfully, but these errors were encountered: