Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Remove UnresolvedBrilligCall #416

Closed
TomAFrench opened this issue Jul 10, 2023 · 1 comment · Fixed by #399
Closed

Remove UnresolvedBrilligCall #416

TomAFrench opened this issue Jul 10, 2023 · 1 comment · Fixed by #399
Labels
enhancement New feature or request

Comments

@TomAFrench
Copy link
Member

Problem

We expose this struct but it's not currently ever used in the regular ACVM execution flow. ForeignCallWaitInfo is all that needs to be exposed.

This struct only existed due to how ACVM execution logic wasn't being implemented in the ACVM.

Happy Case

We should remove the UnresolvedBrilligCall struct.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@TomAFrench TomAFrench added the enhancement New feature or request label Jul 10, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 10, 2023
@TomAFrench
Copy link
Member Author

This is dependent on #399

@TomAFrench TomAFrench linked a pull request Jul 17, 2023 that will close this issue
feat(acvm)!: Support stepwise execution of ACIR #399
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(acvm)!: Support stepwise execution of ACIR noir-lang/acvm
1 participant
@TomAFrench