Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

Deprecate --allow-warnings; Add --deny-warnings #224

Closed
Savio-Sou opened this issue Jul 10, 2023 · 2 comments · Fixed by #227
Closed

Deprecate --allow-warnings; Add --deny-warnings #224

Savio-Sou opened this issue Jul 10, 2023 · 2 comments · Fixed by #227

Comments

@Savio-Sou
Copy link
Contributor

PR: noir-lang/noir#1383

Warnings used to be treated as errors by default, where devs can opt out of the behavior with the --allow-warnings flag.

From v0.7.0 onwards, warnings are treated as warnings by default and the --allow-warnings flag is removed.

A --deny-warnings flag is added for opting in for treating warnings as errors.

@Savio-Sou Savio-Sou added this to Noir Jul 10, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 10, 2023
@Savio-Sou
Copy link
Contributor Author

@TomAFrench not exactly sure what you meant with noir-lang/noir#1383 (comment).

Would you like to elaborate on it a bit?

@TomAFrench
Copy link
Member

Just that if we have any example CI workflows shown in the docs for people to copy-paste, then we should update the flags in there to disallow warnings.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants