Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

Review "Dependencies" Page #49

Closed
Savio-Sou opened this issue Jan 19, 2023 · 8 comments · Fixed by #164 or #165
Closed

Review "Dependencies" Page #49

Savio-Sou opened this issue Jan 19, 2023 · 8 comments · Fixed by #164 or #165

Comments

@Savio-Sou
Copy link
Contributor

Savio-Sou commented Jan 19, 2023

@Savio-Sou Savio-Sou self-assigned this Jan 19, 2023
@Savio-Sou Savio-Sou removed their assignment Feb 21, 2023
@signorecello signorecello transferred this issue from noir-lang/book Mar 30, 2023
@signorecello
Copy link
Collaborator

@Globallager the example is broken, is this still relevant? if so, could we get more information on it?

@Savio-Sou
Copy link
Contributor Author

Feel free to use whatever repo as an example 🙌 Goal is to demonstrate how dependencies are managed, that's all.

@SleepingShell
Copy link
Contributor

@signorecello It would be useful to specify that dep:: must prefix the specified dependency name in Nargo.toml. Had to trial and error this myself to figure that out.

@critesjosh
Copy link
Collaborator

@SleepingShell I updated this in #164

@SleepingShell
Copy link
Contributor

SleepingShell commented May 19, 2023

@critesjosh thank you! I recently came upon this issue, which suggests that local paths can be included as well? This would also be useful information on the page (since I'm only finding out from searching through issues).

noir-lang/noir#1034

@critesjosh
Copy link
Collaborator

@SleepingShell would you be open to creating a PR to update the page with the relevant info?

@SleepingShell
Copy link
Contributor

@critesjosh I hope #165 is good!

@critesjosh
Copy link
Collaborator

@critesjosh I hope #165 is good!

perfect. thank you!

This was linked to pull requests Aug 16, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants