-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to nargo 0.11.0, bbjs 0.5.1 #49
Conversation
✅ Deploy Preview for noir-next-hardhat ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @nomicfoundation/hardhat-network-helpers@1.0.8, @types/react@18.2.19, hardhat@2.17.1, next@13.4.13 |
@signorecello EDIT: I just added |
Getting:
when I attempt to prove in the webpage compile from next-hardhat 🤔 (Circuit compiled with Nargo v0.10.5.) |
@@ -29,7 +29,7 @@ export class NoirBrowser { | |||
this.acirBuffer = Buffer.from(circuit.bytecode, 'base64'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevaundray any changes on how we handle circuit bytecode required per the recent changes re en/decoding base64 on both Noir's and barretenberg's sides?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to headless-test/src/index.ts for quick ref.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made all of the relevant changes in this barretenberg PR: AztecProtocol/aztec-packages@7fffd16
If you follow the examples, it will show how to handle the base64 encoding; essentially, base64 is only in the json file, bb.js and bb require you to base64 decode it before passing it to them
@kevaundray noted that compiling with 0.10.5 will actually fail, but it works fine with nightly. We just pair programmed and tested this. Seems like you used nightly (which is also 0.10.5 but some commits later, hence the confusion). He's pushing a pre-release for 0.10.6 so it should work with 0.10.6 |
We had a breaking change so it will be 0.11.0 -- it should be released now! |
Made some commit suggestions, apart from that, this looks good to me. The issue at play here is the fact that we have not integrated |
Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Co-authored-by: kevaundray <kevtheappdev@gmail.com>
@kevaundray I just updated to 0.11.0 and am seeing this error with ➜ circuits git:(jc/update) ✗ nargo codegen-verifier
The application panicked (crashed).
Message: Backend does not support an opcode that is in the IR: SmartContractError(BackendError("Failed to download srs: Unable to open file: /home/josh/.nargo/backends/acvm-backend-barretenberg/crs/g1.dat\n"))
Location: crates/nargo_cli/src/cli/compile_cmd.rs:96
This is a bug. We may have already fixed this in newer versions of Nargo so try searching for similar issues at https://github.com/noir-lang/noir/issues/.
If there isn't an open issue for this bug, consider opening one at https://github.com/noir-lang/noir/issues/new?labels=bug&template=bug_report.yml Seems weird because the CI tests are passing. |
That's acceptable imo as compilation needs to happen only once and is performed by the developer (rather than user). Compiling in CLI is ok, compilable in Node.js would be nice, compilable in web browsers would be unnecessary for most Noir apps (outliers being e.g. in-browser dev tools). |
I removed ~/.nargo and ~/nargo and reinstalled and it worked. |
Update to nargo 0.11.0 and bb.js 0.5.1.