Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dynamic arrays #1011

Closed
guipublic opened this issue Mar 20, 2023 · 4 comments · Fixed by #1271
Closed

Enable dynamic arrays #1011

guipublic opened this issue Mar 20, 2023 · 4 comments · Fixed by #1271
Assignees
Labels
enhancement New feature or request

Comments

@guipublic
Copy link
Contributor

Problem

Dynamic arrays are implemented in PR #886 but they are disabled within the PR because of verification failing the integration test.

Proposed solution

We should fix the issue and enable dynamic arrays:

  • allows to write arrays with field index type in the fronted
  • enable the integration test in 6_array

Alternatives considered

No response

Additional context

No response

@guipublic guipublic added the enhancement New feature or request label Mar 20, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Mar 20, 2023
@Savio-Sou
Copy link
Collaborator

Is this a duplicate of #507?

@guipublic
Copy link
Contributor Author

No, dynamic arrays are now implemented but they are not activated yet.
The implementation change the index from comptime FieldElement to FieldElement, so the issue #507 remains valid.

@colinnielsen
Copy link

@guipublic are dynamic arrays enabled in nargo 0.3.2?

@guipublic
Copy link
Contributor Author

@guipublic are dynamic arrays enabled in nargo 0.3.2?

No, the test case does not verify. This should not happen since noir proofs should be valid. We have other cases with the same issue (some are very simple) so we suspect a problem on the backend. Since we are going to switch to a new backend very soon, we are just waiting for the new backend.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants