Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support chaining local dependencies #1013

Closed
TomAFrench opened this issue Mar 20, 2023 · 1 comment
Closed

Support chaining local dependencies #1013

TomAFrench opened this issue Mar 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@TomAFrench
Copy link
Member

Problem

Local path based dependencies are generally going to be represented as relative paths so that they're portable across different developers' machines. This has the issue that it relies on knowledge of where the path is relative to.

Currently when handling local dependencies we assume that the path starts from the root crate's root directory however this is unlikely to be the case in 2nd order dependencies (a dependency of a dependency)

Proposed solution

When resolving local dependencies of local dependencies we should modify the path pointing towards the package to account for the fact that it doesn't start from nargo's working directory.

Alternatives considered

No response

Additional context

No response

@TomAFrench
Copy link
Member Author

Closing as this was addressed in #1034

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

1 participant