Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot import dependency that is a child-dependency of another #1380

Closed
1 task
SleepingShell opened this issue May 19, 2023 · 4 comments
Closed
1 task

Cannot import dependency that is a child-dependency of another #1380

SleepingShell opened this issue May 19, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@SleepingShell
Copy link

Aim

Given library A and library B, B depends on A. A crate should be able to import both A and B.

Expected behavior

To be able to use both libraries

Bug

I have tried two scenarios to import library A and B.

  1. List both dependencies in Nargo.toml. This leads to an error:
The application panicked (crashed).
Message:  ice: the same path was inserted into the file manager twice
Location: crates/fm/src/lib.rs:57
  1. Attempt to import lib A without listing it in Nargo.toml. This leads to:
The application panicked (crashed).
Message:  error reporter: could not find crate libA
Location: crates/noirc_frontend/src/hir/resolution/import.rs:199

To reproduce

No response

Installation method

None

Nargo version

nargo 0.5.1 (git version hash: 7f6dede, is dirty: false)

@noir-lang/noir_wasm version

No response

@noir-lang/barretenberg version

No response

@noir-lang/aztec_backend version

No response

Additional context

No response

Submission Checklist

  • Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.
@SleepingShell SleepingShell added the bug Something isn't working label May 19, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir May 19, 2023
@TomAFrench
Copy link
Member

Can you provide a repo where we can reproduce this please?

@SleepingShell
Copy link
Author

SleepingShell commented May 20, 2023

Can you provide a repo where we can reproduce this please?

@TomAFrench Yes, please use this subfolder in this repo: https://github.com/SleepingShell/darkforest-noir/tree/main/init

@kobyhallx kobyhallx moved this from 📋 Backlog to 🤔 Grooming in Noir Jun 19, 2023
@kevaundray
Copy link
Contributor

@TomAFrench what is the status of this issue?

@TomAFrench
Copy link
Member

Resolved in #1034

@github-project-automation github-project-automation bot moved this from 🤔 Grooming to ✅ Done in Noir Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants