chore(stdlib)!: remove unnecessary merkle functions from stdlib #1424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Related to #1258 and noir-lang/acvm#295
Summary*
This PR removes the unnecessary functions from the
merkle
module in the stdlib (check_membership
andcompute_root_from_leaf
).We no longer use the black box version of
compute_merkle_root
in preparation for the opcode being removed and just use the noir implementation (which has been shown to be more efficient anyway).compute_root_from_leaf
is then removed/renamed tocompute_merkle_root
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.