-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nargo): Allow user-specified file for prover inputs instead of Prover.toml
#1531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working through a notification backlog today so will do a more thorough review later on.
Prover.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
need te re-run failed action I believe |
LFG |
Thanks for this @exp-table! |
Description
A short modification of
nargo_cli
to allow the user to specify which.toml
file to use when generating a proof instead of being forced to useProver.toml
.Problem*
The user had no choice but to use
Prover.toml
when generating a proof.This is leading to race conditions when running forge tests (which run in parallel), in particular when these tests use on-the-fly proof generation.
Summary*
Allows the user to optionnally specify which
.toml
file to use with the-p
or--prover-name
flag.This PR sets out to
Example
Before:
After:
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.