-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move printing errors to nargo_cli #1537
Comments
I will take care of it. Do I need to remove the printing from those places, right? noir/crates/noirc_driver/src/lib.rs Lines 194 to 200 in ae7ac21
noir/crates/noirc_driver/src/lib.rs Lines 313 to 314 in ae7ac21
Try introducing a new error type. |
@f01dab1e
Those print lines can stay for now, its mostly just about removing the error printing in noirc_driver and having the caller do the printing.
Yeah I think we need to think about the Diagnostic and CustomDiagnostic types and whether the caller needs to have a FileManager. |
Problem
Currently errors are printed in noirc_driver to stdout, which is counter-intuitive for a crate that should be a library.
Happy Case
We can move the printing of errors to
nargo_cli
insteadAlternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: