Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Brillig code to handle foreign calls #1557

Closed
kevaundray opened this issue Jun 5, 2023 · 3 comments
Closed

Generate Brillig code to handle foreign calls #1557

kevaundray opened this issue Jun 5, 2023 · 3 comments
Assignees
@ludamad
Labels
enhancement New feature or request refactor ssa

Comments

@kevaundray
Copy link
Contributor

kevaundray commented Jun 5, 2023 •
edited
Loading

Problem

This also needs to be specified a bit further, following the fact that we have moved foreign calls into Brillig whereas before they were a concept separate from Brillig.

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added enhancement New feature or request refactor ssa labels Jun 5, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 5, 2023
@kevaundray kevaundray changed the title Generate Brillig code to handle oracles Generate Brillig code to handle foreign calls Jun 5, 2023
@ludamad ludamad self-assigned this Jun 7, 2023
@ludamad ludamad mentioned this issue Jun 7, 2023
Merged
@kevaundray
Copy link
Contributor Author

Going to leave this open as we do not currently generate Brillig code for a foreign function call yet

@vezenovm vezenovm mentioned this issue Jun 8, 2023
Merged
5 tasks
@ludamad ludamad mentioned this issue Jun 9, 2023
Merged
5 tasks
@ludamad
Copy link
Collaborator

ludamad commented Jun 12, 2023 •
edited
Loading

Can this be closed? Admittedly since Maxim finished the feature out I'm not sure

@ludamad ludamad closed this as completed Jun 13, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jun 13, 2023
@ludamad
Copy link
Collaborator

ludamad commented Jun 13, 2023

Enacting "ask forgiveness not permission" :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ludamad ludamad

Labels
enhancement New feature or request refactor ssa
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ludamad @kevaundray