Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ForeignCall instruction #1643

Closed
vezenovm opened this issue Jun 12, 2023 · 3 comments · Fixed by #1644
Closed

Refactor ForeignCall instruction #1643

vezenovm opened this issue Jun 12, 2023 · 3 comments · Fixed by #1644
Assignees
@vezenovm
Labels
enhancement New feature or request

Comments

@vezenovm
Copy link
Contributor

Problem

See comment here (#1600 (comment)).

We should be able to create a new Value type and follow the same flow as intrinsics rather than having a separate ForeignCall instruction.

Happy Case

Remove ForeignCall instruction and maintain same foreign call functionality

Alternatives Considered

The existing work is an alternative as foreign calls work as expected. The solution in this issue will enable us to remove an instruction.

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@vezenovm vezenovm added the enhancement New feature or request label Jun 12, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 12, 2023
This was referenced Jun 12, 2023
Merged
Merged
@ludamad ludamad closed this as completed Jun 13, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jun 13, 2023
@ludamad
Copy link
Collaborator

ludamad commented Jun 13, 2023

oops, mistaken issue

@ludamad ludamad reopened this Jun 13, 2023
@kevaundray
Copy link
Contributor

@vezenovm can this be closed?

@vezenovm
Copy link
Contributor Author

Yes closed by #1644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vezenovm vezenovm

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ssa_refactor): Improve foreign call compilation noir-lang/noir
3 participants
@ludamad @kevaundray @vezenovm