Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow arrays of arbitrary types in the program ABI #1651

Merged
merged 12 commits into from
Jul 11, 2023
Merged

feat: Allow arrays of arbitrary types in the program ABI #1651

merged 12 commits into from
Jul 11, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Jun 13, 2023 •
edited
Loading

Description

Problem*

Resolves #1459

Summary*

This PR sets out to implement support for arrays of arbitrary types.

This requires us to make InputValue more flexible to allow encoding/decoding and we then need to expand this outwards

Example

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench self-assigned this Jun 13, 2023
@github-actions github-actions bot mentioned this pull request Jun 13, 2023
Closed
@TomAFrench
Copy link
Member Author

TomAFrench commented Jun 13, 2023 •
edited
Loading

@joss-aztec Is this expected to work with the new SSA? This currently panics due to the old SSA not supporting arrays of structs.

@jfecher
Copy link
Contributor

jfecher commented Jun 13, 2023

@joss-aztec Is this expected to work with the new SSA? This currently panics due to the old SSA not supporting arrays of structs.

It is expected to work since the new ssa is supposed to support arrays of structs and nested arrays, but we have been unable to test it to verify it works because these are not allowed in the frontend.

jfecher
jfecher reviewed Jun 13, 2023
View reviewed changes
crates/noirc_abi/src/input_parser/json.rs Outdated Show resolved Hide resolved
crates/noirc_abi/src/input_parser/toml.rs Outdated Show resolved Hide resolved
@TomAFrench TomAFrench force-pushed the arbitrary-array-inputs branch from 7705ed4 to ce5992b Compare June 13, 2023 16:30
@TomAFrench TomAFrench mentioned this pull request Jun 13, 2023
Merged
5 tasks
@TomAFrench TomAFrench marked this pull request as ready for review July 11, 2023 02:47
@TomAFrench TomAFrench requested a review from jfecher July 11, 2023 05:07
jfecher
jfecher approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@jfecher jfecher added this pull request to the merge queue Jul 11, 2023
Merged via the queue into master with commit 811ede1 Jul 11, 2023
@jfecher jfecher deleted the arbitrary-array-inputs branch July 11, 2023 13:58
@kevaundray kevaundray mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees

@TomAFrench TomAFrench

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prover.toml doesn't handle arrays of structs
2 participants
@TomAFrench @jfecher