fix(ssa refactor): Fix array elements not being mapped to new values

[jfecher]

Description

Problem*

Resolves #1688 but at what cost? I've spammed .clone()s everywhere due to the function for mapping ValueIds now requiring an &mut self. I'm not satisfied with this approach as a result. I've tried replacing each with the set_value_from_id approach but it caused bugs in loop unrolling presumably from setting the same valueids on each loop iteration.

Summary*

Documentation

• This PR requires documentation updates when merged.

  • I will submit a noir-lang/docs PR.
  • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[jfecher]

Also fixes #1698.

Edit: After merging master again it looks like it does not fix #1698. Presumably another pass like function inlining needs the changes here as well.

[joss-aztec]

I could only find 6 additional clones - your lamentation had me ready for worse!