Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(old ssa): fix to_be_bits #1765

Merged
merged 2 commits into from
Jun 21, 2023
Merged

fix(old ssa): fix to_be_bits #1765

merged 2 commits into from
Jun 21, 2023

Conversation

Ethan-000
Copy link
Contributor

@Ethan-000 Ethan-000 commented Jun 20, 2023 •
edited
Loading

Description

Problem*

Resolves #1400

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
Copy link
Contributor

This looks good -- can you add a regression test perhaps, testing that the to_be_bits version and the to_le_bits version are reverses of each other?

@jfecher jfecher enabled auto-merge June 20, 2023 20:14
@jfecher jfecher added this pull request to the merge queue Jun 20, 2023
Merged via the queue into noir-lang:master with commit 2541fbd Jun 21, 2023
This was referenced Jun 21, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray left review comments

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_le_bits and to_be_bits give the same output
3 participants
@Ethan-000 @kevaundray @jfecher