fix(ssa refactor): allow simplified call inserts & fix const radix arg handling #1774
+83
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joss-aztec
changed the title
jfecher
reviewed
Jun 21, 2023
crates/nargo_cli/tests/test_data_ssa_refactor/to_bytes_integration/src/main.nr
Outdated
Show resolved
Hide resolved
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
The introduction of constant radix simplification broke the function builder when inserting such calls. (Affects test named
to_bytes_integration.)Also radix simplification was wrong reading the radix as the limb count.
Together these fixes get
to_bytes_integrationpassing, and resolve GH-1620.Summary*
Changes the fetching of simplified results into a supported into a supported case for call insertions.
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.