Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add signed division #1831

Merged
merged 4 commits into from
Jul 5, 2023
Merged

feat: add signed division #1831

merged 4 commits into from
Jul 5, 2023

Conversation

guipublic
Copy link
Contributor

@guipublic guipublic commented Jun 27, 2023

Description

Implement signed division by convertir the inputs to unsigned integers, doing the euclidian division there and transforming back the result for the signed numbers

Problem*

Resolves #1790

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@guipublic guipublic changed the title feat: add signed division DO NOT MERGE feat: add signed division Jul 4, 2023
@guipublic guipublic marked this pull request as ready for review July 4, 2023 12:52
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, generally looks okay

@kevaundray kevaundray enabled auto-merge July 4, 2023 17:52
@kevaundray kevaundray added this pull request to the merge queue Jul 5, 2023
Merged via the queue into master with commit d0894ad Jul 5, 2023
@kevaundray kevaundray deleted the gd/signed_div branch July 5, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement signed division
2 participants