Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit Opcodes in correct order from GeneratedAcir::radix_le_decompose #1903

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Jul 10, 2023

Description

Problem*

Fixes test cases for #1729

Summary*

Previously we would

1. Apply range constraints to limbs.
2. Apply arithmetic constraint to limbs.
3. Insert limb values with directive.

It's impossible to solve 1 and 2 without 3 so we have reordered these as

1. Insert limb values with directive.
2. Apply range constraints to limbs.
3. Apply arithmetic constraint to limbs.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from kevaundray July 10, 2023 15:48
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll await another approving review however.

@kevaundray kevaundray enabled auto-merge July 10, 2023 15:55
@kevaundray kevaundray added this pull request to the merge queue Jul 10, 2023
Merged via the queue into master with commit e5fe839 Jul 10, 2023
@kevaundray kevaundray deleted the radix-opcode-ordering branch July 10, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants