fix(brillig_gen): Pass correct size of complex types input for brillig foreign calls #1922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were passing the size of an array from
Type::Array
directly when generating the inputs for a brillig foreign call. This wouldn't break for normal arrays or singular structs, but breaks in the case of an array of structs. For example if we have an array of two structs with two fields each, only the first two fields would be passed to the foreign call as the entire array is of size 2.Problem*
Quick issue found while doing logging PR
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
I have tested the changes locally.
I held off on adding a struct test directly as my println PR will have much more comprehensive tests that deserialize arrays of structs.
I have formatted the changes with Prettier and/or
cargo fmt
on default settings.