-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Various fixes for defunctionalization & brillig gen #1973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stuff with defunctionalize seem that they could use a pass to read less like the raw data structure manipulation operations or raw SSA traversal for function values, but I rather merge fast and let you ponder that longer
LGTM
Also, can we split this up into smaller PRs next time (ideally one per issue)? Many of these changes seem unrelated and this PR solving several issues makes each individual fix more difficult to isolate. It's also easier reviewing several smaller PRs than one larger one, especially if part of the larger PR becomes blocking for the rest of it. |
Description
Problem*
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.