You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The JsonTypes enum is being used inside the nargo crate in order to display InputValue types that have been decoded from foreign calls. We want to restrict the JsonTypes to just the noirc_abi crate.
Happy Case
Decoding a list of field elements to an InputValue and then converting it into a JsonType requires an AbiType. We should make a wrapper around InputValue purely for display called InputValueDisplayWrapper or something similar. This wrapper will contain the InputValue to display and the AbiType. The wrapper's Display implementation will then do the conversion into JsonTypes inside the noirc_abi crate so that we don't expose format types outside of the Abi crate.
Alternatives Considered
N/A
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered:
Problem
Reference this comment in this discussion: #1917 (comment)
The
JsonTypes
enum is being used inside thenargo
crate in order to displayInputValue
types that have been decoded from foreign calls. We want to restrict theJsonTypes
to just thenoirc_abi
crate.Happy Case
Decoding a list of field elements to an
InputValue
and then converting it into aJsonType
requires anAbiType
. We should make a wrapper aroundInputValue
purely for display calledInputValueDisplayWrapper
or something similar. This wrapper will contain theInputValue
to display and theAbiType
. The wrapper'sDisplay
implementation will then do the conversion intoJsonTypes
inside thenoirc_abi
crate so that we don't expose format types outside of the Abi crate.Alternatives Considered
N/A
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: