Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the obsolete flat_witness feature flag from Nargo #2010

Closed
Savio-Sou opened this issue Jul 24, 2023 · 1 comment · Fixed by #2208
Closed

Remove the obsolete flat_witness feature flag from Nargo #2010

Savio-Sou opened this issue Jul 24, 2023 · 1 comment · Fixed by #2208
Assignees
Labels
enhancement New feature or request

Comments

@Savio-Sou
Copy link
Collaborator

Problem

The flattened witness format has been adopted as the default approach to formatting witnesses generated.

The flat_witness feature flag seems obsolete in consideration of so.

Happy Case

Merge-to-master or remove experimental works under the feature flag, and remove the flag.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@Savio-Sou Savio-Sou added the enhancement New feature or request label Jul 24, 2023
@Savio-Sou Savio-Sou added this to Noir Jul 24, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 24, 2023
@kevaundray
Copy link
Contributor

@vezenovm assigned this to you, please check if we do need this and document what has changed for us to no longer need this.

cc @TomAFrench

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants