Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen the coupling between Acir::BlockId and Id<Value> #2015

Closed
kevaundray opened this issue Jul 24, 2023 · 0 comments · Fixed by #2103
Closed

Loosen the coupling between Acir::BlockId and Id<Value> #2015

kevaundray opened this issue Jul 24, 2023 · 0 comments · Fixed by #2103
Assignees
@guipublic
Labels
acir-gen enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

See : #1969 (comment)

When we create a new BlockId in Acir, it should ideally start at 0 and not an arbitrary number set by the SSA IR.

Happy Case

To do this we would just need to create a new map in acir gen that increments the BlockId.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guipublic guipublic

Labels
acir-gen enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Decouple acir blockid from ssa valueid noir-lang/noir
2 participants
@kevaundray @guipublic