Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a JS package to handle ABI encoding/decoding #2025

Closed
TomAFrench opened this issue Jul 25, 2023 · 3 comments · Fixed by #1945
Closed

Add a JS package to handle ABI encoding/decoding #2025

TomAFrench opened this issue Jul 25, 2023 · 3 comments · Fixed by #1945
Assignees

Comments

@TomAFrench
Copy link
Member

Problem

Currently acvm_js assumes that the caller can provide an initial witness with which to execute the circuit.

This is fine for relatively simple programs but it's not a good experience and makes more complex noir programs unwieldy to work with.

Happy Case

In order to interact with Noir programs in the browser we need a way to construct the initial witness from a set of inputs similar to what we have in Prover.toml.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response

@TomAFrench TomAFrench self-assigned this Jul 25, 2023
@TomAFrench TomAFrench transferred this issue from noir-lang/.github Jul 25, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 25, 2023
@TomAFrench TomAFrench linked a pull request Jul 25, 2023 that will close this issue
5 tasks
@Savio-Sou
Copy link
Collaborator

Add a JS package

Is there any value for it to live as a standalone package? Would it make sense to merge it into noir_wasm or acvm_js?

@TomAFrench
Copy link
Member Author

Neither of those two packages are good spots for this functionality to live tbh.

noir_wasm: This would require a user to load a complete copy of the noir compiler in order to construct initial witnesses.
acvm_js: See noir-lang/acvm-simulator#4

@Savio-Sou
Copy link
Collaborator

Hmm reasonable.

The need for wrapping everything into one Noir.js package as an option seems to be growing. Fiddling with 4+ packages just to get started sounds like a DevEx nightmare.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants