Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Perform occurs check before binding function types #2027

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jul 25, 2023

Description

Problem*

Resolves #2009

Summary*

Previously when type checking function calls if the function was an unbound type variable we'd bind the type variable without performing an occurs check first. This lead to us creating infinitely recursive types such as a = (fn(a) -> ()) as in the issue above. Since we should never bind without performing an occurs check in general, I've made a helper function to help avoid this in the future.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray added this pull request to the merge queue Jul 25, 2023
Merged via the queue into master with commit 1544786 Jul 25, 2023
@kevaundray kevaundray deleted the jf/fix-bind-function branch July 25, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite types lead to stack overflow
3 participants