Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Compile twice and hash bytecode to check for non-determinism #2036

Closed
vezenovm opened this issue Jul 25, 2023 · 0 comments · Fixed by #6847
Closed

Testing: Compile twice and hash bytecode to check for non-determinism #2036

vezenovm opened this issue Jul 25, 2023 · 0 comments · Fixed by #6847
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@vezenovm
Copy link
Contributor

Problem

We should have logic as part of our test-suite to make sure that we don't produce non-deterministic circuits for the same Noir code. This fix (#2035) was recently pushed through as 9_conditional was generating non-deterministic bytecode.

Happy Case

We should catch any non-determinism in our test-suite.

Alternatives Considered

Re-running compilation twice will slow down our CI. Perhaps we should note any critical areas where there is a higher potential for non-determinism (such as merging conditional branches) and only re-compile these programs.

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants