-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply ssa optimizations to brillig functions #2066
Comments
I think this issue should be implemented in phases:
|
A good starting point for this issue would be the runtime separation pass. An example of reachability analysis for Brillig funcs is already performed here: https://github.com/noir-lang/noir/blob/master/crates/noirc_evaluator/src/brillig/mod.rs#L59. These ACIR funcs called from Brillig would then be cloned and replaced with a Brillig runtime. |
For reference, once this is complete, we should remove the code added in this PR : #2190 |
Problem
Right now brillig is generated before any ssa optimizations are applied. We should generate brillig just before ACIR is generated, after all optimization steps are applied.
Happy Case
All optimization steps apply succesfully to ssa containing both brillig and acir functions.
Alternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: