Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CrateType should be a nargo concept #2073

Closed
phated opened this issue Jul 27, 2023 · 0 comments · Fixed by #2134
Closed

CrateType should be a nargo concept #2073

phated opened this issue Jul 27, 2023 · 0 comments · Fixed by #2134
Assignees
@phated
Labels
enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented Jul 27, 2023

Problem

CrateType is leaked into the frontend, but it only matters in the context of nargo. We should move the concept into nargo itself.

Happy Case

The compiler frontend takes any code and compiles it, and nargo has extra logic for determining what that means for libraries/binaries/contracts.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response
@phated phated added the enhancement New feature or request label Jul 27, 2023
@phated phated self-assigned this Jul 27, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 27, 2023
This was referenced Jul 27, 2023
Closed
Merged
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phated phated

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(nargo)!: Require package type be specified in Nargo.toml noir-lang/noir
1 participant
@phated