Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate noir-lang/build-nargo into this repository #2188

Closed
TomAFrench opened this issue Aug 4, 2023 · 1 comment · Fixed by #2211
Closed

Integrate noir-lang/build-nargo into this repository #2188

TomAFrench opened this issue Aug 4, 2023 · 1 comment · Fixed by #2211
Assignees
Labels
enhancement New feature or request

Comments

@TomAFrench
Copy link
Member

Problem

The Nargo release process is currently split off into the noir-lang/build-nargo repository which handles building Nargo binaries and adding them to release tags. This separation causes issues as we've had a good number of times where we create a release and it's unable to create binaries due to issues which only occur in the release flow.

Happy Case

We should integrate those workflows into the CI of this repository. We can then use the built binaries to implement #2013 and also run the full cross-compilation flows on any release-please PR which while block any broken release.

Alternatives Considered

#1921 uses the output of one of these release flows already so we can start amortising these build times across CI workflows.

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@TomAFrench TomAFrench added the enhancement New feature or request label Aug 4, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 4, 2023
@kevaundray
Copy link
Contributor

@TomAFrench are you taking this on?

@TomAFrench TomAFrench self-assigned this Aug 8, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants