Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full call stack to the Location information in SSA #2214

Closed
jfecher opened this issue Aug 8, 2023 · 0 comments · Fixed by #2310
Closed

Add full call stack to the Location information in SSA #2214

jfecher opened this issue Aug 8, 2023 · 0 comments · Fixed by #2310
Assignees
Labels
enhancement New feature or request ssa

Comments

@jfecher
Copy link
Contributor

jfecher commented Aug 8, 2023

Problem

When an assert or some other error occurs, the erroring line is pointed out with no context as to how the program execution got to that point. This is particularly problematic if the error occurs within a library.

Happy Case

Instead of storing Option<Location> for an instruction, we should store Vec<Location> where each instruction originally holds only the absolute location, and it is eventually pushed to over time during each function inlining step adding a stack frame.

We would need to rework the way errors are displayed to enable them to show full stack traces.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@jfecher jfecher added enhancement New feature or request ssa P-LOW labels Aug 8, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 8, 2023
@Ethan-000 Ethan-000 mentioned this issue Aug 14, 2023
2 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ssa
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants