Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider passing through TARGET_CC & TARGET_AR in Cross.toml for rustls #2278

Closed
phated opened this issue Jan 24, 2023 · 3 comments
Closed
Labels
CI enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented Jan 24, 2023

According to the ring (dependency of rustls), the TARGET_CC and TARGET_AR env variables are required to cross-compile it.

Our cross-compilation seems fine, but we might want to provide these in the Cross.toml file. 🤷

[target.x86_64-unknown-linux-gnu.env]
passthrough = [
    "TARGET_CC=x86_64-linux-gnu-gcc",
    "TARGET_AR=x86_64-linux-gnu-ar",
]

[target.x86_64-unknown-linux-musl.env]
passthrough = [
    "TARGET_CC=x86_64-linux-musl-gcc",
    "TARGET_AR=x86_64-linux-musl-ar",
]

[target.aarch64-unknown-linux-gnu.env]
passthrough = [
    "TARGET_CC=aarch64-linux-gnu-gcc",
    "TARGET_AR=aarch64-linux-gnu-ar",
]

[target.aarch64-unknown-linux-musl.env]
passthrough = [
    "TARGET_CC=aarch64-linux-musl-gcc",
    "TARGET_AR=aarch64-linux-musl-ar",
]
@phated
Copy link
Contributor Author

phated commented Jan 24, 2023

Ref noir-lang/build-nargo#3

@kevaundray
Copy link
Contributor

Now that we have moved the contents of this to noir-lang -- should we transfer over this issue?

@TomAFrench TomAFrench changed the title TARGET_CC & TARGET_AR for rustls? Consider passing through TARGET_CC & TARGET_AR in Cross.toml for rustls Aug 11, 2023
@TomAFrench TomAFrench transferred this issue from noir-lang/build-nargo Aug 11, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 11, 2023
@Savio-Sou Savio-Sou added enhancement New feature or request CI labels Nov 2, 2023
@Savio-Sou
Copy link
Collaborator

Savio-Sou commented Nov 2, 2023

We might skip this piece if we're taking #2275 on (?)

Assigning P-LOW as it seems like the work is not blocking other efforts.

Guessing E-LOW.

@kevaundray kevaundray closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants