Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to opt-out of default-member in a workspace #2311

Closed
phated opened this issue Aug 14, 2023 · 0 comments · Fixed by #2313
Closed

No way to opt-out of default-member in a workspace #2311

phated opened this issue Aug 14, 2023 · 0 comments · Fixed by #2313
Assignees
Labels
enhancement New feature or request

Comments

@phated
Copy link
Contributor

phated commented Aug 14, 2023

Problem

Currently, there is no way to opt-out of building only the default package in a workspace that specifies default-member in the Nargo.toml

This becomes a problem if trying to build the entire workspace, such as when the LSP needs to provide feedback for a file in a non-default package inside a workspace.

In Cargo, they have the --workspace flag that opts-out of the "default" member and instead runs the command in the entire workspace.

Happy Case

The minimum is that the LSP should have a way to build all packages in a workspace. But it would be even better if a user could also use a --workspace flag to run the command against the entire workspace.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response

@phated phated added the enhancement New feature or request label Aug 14, 2023
@phated phated self-assigned this Aug 14, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 14, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant