Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for attributes on structs #2733

Merged
merged 8 commits into from
Sep 21, 2023
Merged

feat: add support for attributes on structs #2733

merged 8 commits into from
Sep 21, 2023

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Sep 16, 2023 •
edited
Loading

related to this work

Stage

RFC

Description

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@Maddiaa0 Maddiaa0 marked this pull request as ready for review September 18, 2023 09:56
jfecher
jfecher previously approved these changes Sep 18, 2023
View reviewed changes
@Maddiaa0 Maddiaa0 requested a review from jfecher September 19, 2023 13:55
jfecher
jfecher previously approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming discussion can be saved for a later PR. No use blocking this one over it

@Maddiaa0 Maddiaa0 added this pull request to the merge queue Sep 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 19, 2023
@kevaundray
Copy link
Contributor

@Maddiaa0 can you resolve conflicts then we can merge

@kevaundray kevaundray added this pull request to the merge queue Sep 20, 2023
Merged via the queue into master with commit 7b3df8e Sep 21, 2023
15 of 16 checks passed
@kevaundray kevaundray deleted the md/struct-attributes branch September 21, 2023 00:09
@kevaundray kevaundray mentioned this pull request Sep 21, 2023
Merged
@TomAFrench TomAFrench mentioned this pull request Sep 21, 2023
Merged
5 tasks
@jfecher jfecher mentioned this pull request Jun 17, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

@jfecher jfecher jfecher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maddiaa0 @kevaundray @jfecher