Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: constrain is now a hard error #2758

Merged
merged 3 commits into from
Sep 20, 2023
Merged

feat!: constrain is now a hard error #2758

merged 3 commits into from
Sep 20, 2023

Conversation

guipublic
Copy link
Contributor

Description

Using constrain keyword now result into an error.

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher
Copy link
Contributor

jfecher commented Sep 20, 2023

Looks like we still use constrain in the parse_constrain test which is causing this PR to fail

jfecher
jfecher previously approved these changes Sep 20, 2023
View reviewed changes
@jfecher jfecher added this pull request to the merge queue Sep 20, 2023
Merged via the queue into master with commit 388a2b1 Sep 20, 2023
@jfecher jfecher deleted the gd/constrain_error branch September 20, 2023 20:09
@kevaundray kevaundray mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guipublic @jfecher