Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring main export from noir_js to aggregate different Noir steps #2835

Closed
3 tasks done
signorecello opened this issue Sep 26, 2023 · 1 comment
Closed
3 tasks done

Comments

@signorecello
Copy link
Contributor

signorecello commented Sep 26, 2023

Part of the first noir_js review:

I need to import Backend but Backend is literally a copy of noir-starter noir.ts file, plus it’s nested within a test folder.

import { Backend } from '@noir-lang/noir_js/test/backend/barretenberg'

I'm suggesting that we:

  • Should put Backend in the src folder
  • Should export Backend in the package.json file
  • The Backend file is what Noir_js should be, aggregating circuit compilation, witness generation, and the backend. Currently it is literally just a wrapper on barretenberg. At least witness generation would be necessary to include.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 26, 2023
@signorecello signorecello changed the title Refactoring main export from noir.js to aggregate different Noir steps Refactoring main export from noir_js to aggregate different Noir steps Sep 26, 2023
@kevaundray
Copy link
Contributor

Closing this as I believe its completed -- if this is incorrect, feel free to reopen

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants