Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new noir_js versions on NPM automatically #2884

Closed
Savio-Sou opened this issue Sep 28, 2023 · 3 comments
Closed

Release new noir_js versions on NPM automatically #2884

Savio-Sou opened this issue Sep 28, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Savio-Sou
Copy link
Collaborator

Problem

Right now noir_js releases are pushed onto NPM manually. (Or are they expected to be automatic? This would be a bug if that's the case.)

As such, the latest noir_js on NPM is still at v0.12.0 at the moment of creating this issue, in comparison to the latest v0.14.1 Noir / Nargo available.

https://www.npmjs.com/package/@noir-lang/noir_js?activeTab=versions

Happy Case

A noir_js release should be cut and pushed when a Noir release PR is merged, like how Nargo is released.

Alternatives Considered

No response

Additional Context

Ideally we would want noir_js releases to be pushed under the "dev" tag when a Noir Pre-release is cut, and updated to the "latest" tag when the corresponding Noir Pre-release is switched into a Release.

This could go into a separate GitHub Issue however if it's considered a scope creep.

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray
Copy link
Contributor

I think there is an issue with the js publishing workflow -- I can check why these are not publishing or @jonybur

@jonybur
Copy link
Contributor

jonybur commented Oct 2, 2023

@kevaundray Fixing here: #2926

@Savio-Sou
Copy link
Collaborator Author

Duplicate of #2881.

@Savio-Sou Savio-Sou closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants