Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include quotes when printing values #2904

Closed
vezenovm opened this issue Sep 29, 2023 · 3 comments · Fixed by #3574
Closed

Do not include quotes when printing values #2904

vezenovm opened this issue Sep 29, 2023 · 3 comments · Fixed by #3574
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@vezenovm
Copy link
Contributor

Problem

Currently any calls to println will print the value to stdout with quotes. This includes strings, integers, etc.

For example in this snippet:

#[test]
fn test_println()
{
    dep::std::println("");   // outputs {""}     instead of { }
    dep::std::println("A");  // outputs {"A"}    instead of {A}
    dep::std::println("\t"); // outputs {"    "} instead of {    }
}

Happy Case

The snippet outlines what should be printed and what happens instead. We do not want quotes around everything we print. The string "A" should just be printed as A.

Alternatives Considered

N/A otherwise it gets confusing with the quotations and makes it less clear to developers who are debugging. Quotations should just be used for encapsulating strings and only included in a print when they are used with escape characters.

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@vezenovm vezenovm added enhancement New feature or request good first issue Good for newcomers labels Sep 29, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 29, 2023
@rahultg1411
Copy link

Hey, I'm Rahul. I would like to work on this issue. Could you please assign it to me?

@vezenovm
Copy link
Contributor Author

vezenovm commented Oct 2, 2023

Hey thanks for taking this on! @rahultg1411

@grasshopper47
Copy link
Contributor

@vezenovm I've fix this with this PR #3574

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants