Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS to the acir serialization codegen file #2966

Closed
kevaundray opened this issue Oct 3, 2023 · 1 comment
Closed

Add CODEOWNERS to the acir serialization codegen file #2966

kevaundray opened this issue Oct 3, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

If the serialization changes, then its a breaking change that breaks every backend. Tom pointed out that assigning codeowners would be good so that these changes do not get past code review by one of said code owners.

Comment: #2961 (comment)

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray kevaundray added the enhancement New feature or request label Oct 3, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Oct 3, 2023
@kevaundray
Copy link
Contributor Author

Closing until the need for this pops up due to a lot of people editing the file and not knowing what the repercussions are

@kevaundray kevaundray closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants