We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently users need to write code that looks like this:
let x = dep::std::hash::pedersen_with_separator([a,b,c],value)[0];
Writing [0] to get the x value hurts readability.
We can create a struct like so:
struct PedersenPoint { x : Field, y : Field, }
Then change pedersen_with_separator to be named __pedersen_with_separator while the pub keyword is not in full effect yet.
pedersen_with_separator
__pedersen_with_separator
Then have pedersen_with_seperator look something like:
fn pedersen_with_separator(...) -> PedersenPoint{ let values = __pedersen_with_separator(...); PedersenPoint { x: values[0], y: values[1], } }
The result would then be:
let x = dep::std::hash::pedersen_with_separator([a,b,c],value).x;
No response
This is a breaking change
No
The text was updated successfully, but these errors were encountered:
guipublic
Successfully merging a pull request may close this issue.
Problem
Currently users need to write code that looks like this:
Writing [0] to get the x value hurts readability.
Happy Case
We can create a struct like so:
Then change
pedersen_with_separator
to be named__pedersen_with_separator
while the pub keyword is not in full effect yet.Then have pedersen_with_seperator look something like:
The result would then be:
Alternatives Considered
No response
Additional Context
This is a breaking change
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: